Fix dtype selective build check in elementwise_util #12183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12183
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated FailureAs of commit 71d32cc with merge base 02454eb ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
This was referenced Jul 2, 2025
kimishpatel
reviewed
Jul 6, 2025
Comment on lines
+322
to
+325
| constexpr ScalarType out_specialized_scalar_type = | ||
| specialized_output_scalar_type<CTYPE_COMPUTE>(out_dtypes); | ||
| if constexpr (should_include_kernel_dtype( | ||
| op_name, out_specialized_scalar_type)) { |
Contributor
There was a problem hiding this comment.
use of should_include_kernel_dtype is behind a macro, should we not continue with that convention?
Contributor
Author
There was a problem hiding this comment.
ET_INTERNAL_CHECK_SELECTIVE_BUILD depends implicitly on et_switch_name being defined, which doesn't make sense here, and should_include_kernel_dtype is a perfectly good constexpr function so I don't see why we shouldn't call it
lucylq
approved these changes
Jul 7, 2025
Contributor
Author
|
unittest-editable failure looks like a known flake. merging. |
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
I think I got this wrong in pytorch#11975 -- the compute_dtype is the one type that is NOT related to selective build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I got this wrong in #11975 -- the compute_dtype is the one type that is NOT related to selective build.